Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old PPSSPP that support Gundam Vs Gundam Next Plus Adhoc #11497

Closed
NgJinXiang14 opened this issue Oct 27, 2018 · 33 comments
Closed

Old PPSSPP that support Gundam Vs Gundam Next Plus Adhoc #11497

NgJinXiang14 opened this issue Oct 27, 2018 · 33 comments

Comments

@NgJinXiang14
Copy link

Hello,is it possible to use the code from the old PPSSPP build that support Gundam VS Gundam Next Plus adhoc to merge into new version?
The newest version of PPSSPP (1.7) still could not support adhoc on this game.Or is there anything i can help with?

Old version PPSSPP by Onelight (Forum Thread): http://forums.ppsspp.org/showthread.php?tid=12357

@hrydgard
Copy link
Owner

I think it would be better to figure out what broke adhoc in the game and fix that. Could you try some old builds to figure out when it broke?

@lightfirst
Copy link

It was a hack build, help adhoc in Gundam VS Gundam Next Plus but broke Phantasy Star

@ghost
Copy link

ghost commented Nov 2, 2018

And the modded apk v1.7-15 is buggy can't even touch the settings because the touchscreen doesn't respond :/

@NgJinXiang14
Copy link
Author

NgJinXiang14 commented Nov 2, 2018

@Emulatorer Uhhh,yeah,please disable the immersive mode to make it works,it seems that custom build has problem with immersive mode

@NgJinXiang14
Copy link
Author

NgJinXiang14 commented Nov 2, 2018

@hrydgard I think you misunderstand my statement ,i mean it is a custom build ppsspp based on old version PPSSPP, Official one,from old to new cant support the multiplayer as it broke when starting the game at AdHoc Mode. What i want to ask if can merge the code and make it into a option in official build? Oh,and like @lightfirst say,it broke the phantasy star so better make it a option in setting,right?
Sry for the bad english.
screenshot_20181102-131320

PS: The coder of that custom build PPSSPP just update it recently to 1.7 and heres the proof it can work.

@hrydgard
Copy link
Owner

hrydgard commented Nov 2, 2018

Well this custom build maker should share whatever changes he made, so we can incorporate them. He is required to do so by the GPL license.

@ghost
Copy link

ghost commented Nov 2, 2018

There's already a PR for Adhoc Multiplayer Chat Support #7451 #9090

wait for it to merged?

ps, sorry for my bad english :)

@lightfirst
Copy link

@hrydgard The change code at here lightfirst/PPSSPP@0fd927d

Do we really need this hack?

@lightfirst
Copy link

@Emulatorer mod v1.7-15 working fine for me, maybe you should try Restore PPSSPP's settings to default or delete ppsspp.ini and controls.ini at /sdcard/PSP/SYSTEM

@hrydgard
Copy link
Owner

hrydgard commented Nov 2, 2018

I guess we could make it a game specific compatibility setting until a proper fix can be found.

@hrydgard hrydgard added this to the v1.8.0 milestone Nov 2, 2018
@ghost
Copy link

ghost commented Nov 2, 2018

@lightfirst I already fix the issue in touchscreen but some games seems running slow compare to the official build/version and also the graphics display is like force to X2 HW rendering resolution even if it set to native

@lightfirst
Copy link

@Emulatorer Did you compare to the official 1.7-15?

@ghost
Copy link

ghost commented Nov 2, 2018

Yes

@lightfirst
Copy link

It can't be, I just add a hack for gvgnp and merged Chat Support #7451 #9090 the speed and graphics should same as official build

@NgJinXiang14
Copy link
Author

@lightfirst Actually,I also face the same problem,if official build I can use till 4x,with that version max resolution is only 2x

@ghost
Copy link

ghost commented Nov 2, 2018

As a proof of my comment about HW display resolution
PPSSPP BuildHack
screenshot_2018-11-02-21-17-31

PPSSPP OFFICIAL 1.7-15
screenshot_2018-11-02-21-18-27

@ghost
Copy link

ghost commented Nov 2, 2018

As you can see there are more lines in ppsspp buildhack compare to the official build that is a little bit clear 😅

@lightfirst
Copy link

@Emulatorer It should working fine after ppsspp-1.7.1-125-Chat-GVG

@adenovan
Copy link
Contributor

adenovan commented Nov 8, 2018

i guess jpcsp multiplayer working with this game , i am on progress writing adhoc multiplayer relay micro service and deciding to implementing everything on SceNetAdhoc from scratch , HLE function LOG on successfull multiplayer should be a great help to troubleshoot the problem.

PPSSPP networking code really need an update , some high level network library also can be helpfull than relying on C code networking api. working with buffer, endianess ,and many other network stuff on PPSSPP source code is really a pain. im really suggesting ppsspp use ENET as networking library and implement packet class to work on buffer like citra do on their networking folder,

this will make the development of networking part a lot easier and may can improve latency over internet.

looking at lightfirst hack code i think its a race condition with other hlecall and the connect call block the entire networking part. could someone dump the log on this thread?

@lightfirst
Copy link

yes, jpcsp multiplayer working with this game and more games

@adenovan
Copy link
Contributor

adenovan commented Nov 13, 2018

looks like the code that fix phantasy star one is the broken one , it race within matching thread if the matching thread get incomplete data from pdprecv the multiplayer is broken. and the connect function blocking the game for buying time on matching event.

suggest fix don't use PDP function to handle the matching event , instead we must simulate it on other socket like jpcsp do, have one socket to arbitrate like scenetadhocctl does!

related #9120

@unknownbrackets
Copy link
Collaborator

Is this a duplicate of #7444?

-[Unknown]

@hrydgard hrydgard modified the milestones: v1.8.0, v1.9.0 Feb 13, 2019
@hrydgard hrydgard modified the milestones: v1.9.0, v1.10.0 Aug 7, 2019
@hrydgard hrydgard removed this from the v1.10.0 milestone Apr 26, 2020
@southern-dust
Copy link

Does anyone try to figure out this issue on Newest version of PPSSPP for GVGNP?

@ghost
Copy link

ghost commented Aug 8, 2020

This issue is already been fixed by #13182 or not?

@southern-dust
Copy link

This issue is already been fixed by #13182 or not?

yep, seems fixed!

@unknownbrackets unknownbrackets added this to the v1.11.0 milestone Aug 16, 2020
@lightfirst
Copy link

lightfirst commented Aug 16, 2020

Well, it fixed, adhoc working fine on windows, but when play whith android, disconnect appeared in the middle of the multiplayer battle. (same as my hack builds)

@innorage
Copy link

innorage commented Aug 18, 2020

May I know which version's fixed? I tried the latest 1.10.3, could see my friend in multiplayer, but the game wouldn't load after I clicked start. Btw, this applies to multiplayer between PPSSPP right?

@unknownbrackets
Copy link
Collaborator

We close bugs as soon as they are fixed in git, we don't wait until the next stable release which might be weeks or months away. This issue was fixed since v1.10.3 was released, so you'd have to use a git build.

That said, reopening if it's still an issue on Android. Presumably that's a port # issue?

-[Unknown]

@lightfirst
Copy link

May I know which version's fixed? I tried the latest 1.10.3, could see my friend in multiplayer, but the game wouldn't load after I clicked start. Btw, this applies to multiplayer between PPSSPP right?

v1.10.3-198 and up. you can get PPSSPP builds from https://buildbot.orphis.net/ppsspp/index.php?m=fulllist

@leoxxx
Copy link
Contributor

leoxxx commented Oct 4, 2020

#13182
Can start game & linkable more games, but unstable.

@hrydgard
Copy link
Owner

How is this now?

@hrydgard hrydgard modified the milestones: v1.11.0, v1.12.0 Nov 10, 2020
@leoxxx
Copy link
Contributor

leoxxx commented Nov 11, 2020

@hrydgard
1.10.3-917 is better than before.
Thanks for your work.

@hrydgard
Copy link
Owner

Well, on this, mainly @anr2me 's work to be fair :) I'll close this issue, feel free to open new ones with specific issues.

@unknownbrackets unknownbrackets modified the milestones: v1.12.0, v1.11.0 Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants