Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prince of Persia - Rival Swords (USA) fire graphics glitch #11587

Open
benderscruffy opened this issue Nov 25, 2018 · 4 comments
Open

Prince of Persia - Rival Swords (USA) fire graphics glitch #11587

benderscruffy opened this issue Nov 25, 2018 · 4 comments
Labels
GE emulation Backend-independent GPU issues
Milestone

Comments

@benderscruffy
Copy link

benderscruffy commented Nov 25, 2018

just as the screen is scrolling across the menu screen all the fires glitch up
rival
DUMP DX11.ZIP

@unknownbrackets
Copy link
Collaborator

Hm, something is clearly buggy in the dump - might not have pulled the CLUT properly?

From 0x04088000, it does the RGB clut thing. First draw modulates vertex colors, looks fine. Second draw uses an R clut, looks fine. But then it uses a R clut with R masked out, so it essentially erases anything but red.

Hm.

Is the problem this issue is about (not the above dump bug) new or has it always happened?

-[Unknown]

@unknownbrackets
Copy link
Collaborator

It might help to see one from where there are no fires / no issues.

-[Unknown]

@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Aug 14, 2022
@hrydgard hrydgard added this to the v1.14.0 milestone Aug 14, 2022
@hrydgard
Copy link
Owner

There are weird glitches with fire in the other Prince of Persia game too, Revelations. Fire sprites will suddenly glitch in various ways.

In that game, it looks like bogus texture coordinates coming all the way from the CPU. Could be that the game is mismanaging the data cache somehow...

@unknownbrackets
Copy link
Collaborator

Some notes about this here:
#16131 (comment)

A frame dump draws these artifacts so it seems like it's CPU/HLE/something... the values causing this are UVs that seem like they should be 0, but are set to s16 halves of a pointer instead, which is why you get the weird glitching.

-[Unknown]

@hrydgard hrydgard modified the milestones: v1.14.0, Future-Prio Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

No branches or pull requests

3 participants