Optimize out some stencil emulation, try to avoid depth write #11620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it doesn't always apply.
This reduces use of replaceAlpha, and reduces use of more complicated blend states. This simplifies fragment shaders a little.
It seems like depth gets messed up either way on discard, but behaves sorta better without the write to depth.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11535 (comment) - depth is basically broken no matter what you do. If stencil is not involved, then early depth tests are mostly the better broken.
Probably fixes #11583, at least there's no visible issue in that scene with the broken depth testing now (though there might be weird artifacts around it, not sure.) Doesn't help #11535.
Also, the optimization mostly prevents
vec4(v, 0.0)in many cases when it's unnecessary, and cuts down on blending.-[Unknown]