Vulkan: Limit stencil workaround to Adreno 5xx #11694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With device restore etc. everywhere.
unknownbrackets
force-pushed
the
draw-bugs
branch
from
4ecaa76
to
6e772ef
Compare
hrydgard
approved these changes
Dec 23, 2018
| bool Has(uint32_t bug) const { | ||
| return (flags_ & (1 << bug)) != 0; | ||
| } | ||
| void Infest(uint32_t bug) { |
| if (caps_.vendor == GPUVendor::VENDOR_QUALCOMM) { | ||
| // Adreno 5xx devices, all known driver versions, fail to discard stencil when depth write is off. | ||
| // See: https://github.com/hrydgard/ppsspp/pull/11684 | ||
| if (deviceProps.deviceID >= 0x05000000 && deviceProps.deviceID < 0x06000000) { |
There was a problem hiding this comment.
Ah, didn't realize they exposed such nice deviceID numbers. I wonder how reliable they are, but I guess we'll find out if they aren't.
There was a problem hiding this comment.
Right, I had checked several on vulkan.gpuinfo.org, they seemed pretty darn consistent, e.g. Adreno 418 =0x04010800 (sometimes the lowest bit is 1 or so, probably means a hardware revision of some kind.)
-[Unknown]
This also allows the ini setting to avoid it on Intel.
unknownbrackets
force-pushed
the
draw-bugs
branch
2 times, most recently
from
b739059
to
8d6e44c
Compare
Was no longer affecting behavior...
unknownbrackets
force-pushed
the
draw-bugs
branch
from
8d6e44c
to
58ef662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves several bug checks to Draw as well, so that there's one place rather than multiple different ways we check for these bugs (e.g.
gl_extensions.bugs.)Doesn't move the PowerVR precision bugs since I couldn't decide whether to make those shader id bits or not.
While messing with the stencil workaround, limits it to depth write disabled only (which seems safe so far.) Fixes #11535 (by dodging that driver bug.) May impact #11583.
-[Unknown]