Correct vocp / vsocp prefix handling #11835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See hrydgard#5549. Matches tests for various prefix settings.
Very similar to vsop, just with a bit more fixed values.
Verified by tests. Also, confirmed that the old vxbz encoding had no output, but the new position (as used by gas) does.
Not sure any games actually use them, but good to have the remaining vfpu ops all implemented.
unknownbrackets
force-pushed
the
vfpu-artdink
branch
from
a5e27ac
to
aff1d8e
Compare
|
Very nicely investigated! This makes a ton of sense, of course. |
This was referenced Mar 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've become suspicious of vbfy's prefix handling, but haven't tested it yet.Indeed, vbfy does this too. This explains much weird prefix behavior.Previously I had tested prefix handling on vscl, and it behaved strangely when used with t. Now it seems obvious that regnum swizzle was fixed, and probably explains why constants seemed to behave strange.
Also added vsbz/vlgb based on tests (they are pretty straight forward.) Didn't really test prefixes with them, though.
-[Unknown]