Win32 handle leak fix #11842
Merged
Win32 handle leak fix #11842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -133,6 +133,7 @@ std::string ResolvePath(const std::string &path) { | |||
| int result = getFinalPathNameByHandleW(hFile, buf, BUF_SIZE - 1, FILE_NAME_NORMALIZED | VOLUME_NAME_DOS); | |||
| if (result >= BUF_SIZE || result == 0) | |||
| wcscpy_s(buf, BUF_SIZE - 1, input.c_str()); | |||
| CloseHandle(hFile); | |||
There was a problem hiding this comment.
Arg, oops. Thanks.
-[Unknown]
| if (filePath_.empty()) { | ||
| // Happens when workqueue tries to figure out priorities in PrioritizedWorkQueue::Pop(), | ||
| // because priority() calls GetFileLoader()... gnarly. | ||
| return fileLoader; |
There was a problem hiding this comment.
Just remember that for some loaders, e.g. ones that involve memory caching or http access, the cost of tossing this in the bin and getting a new one a couple times is much higher. Ideally we shouldn't recreate just because that's easiest.
-[Unknown]
There was a problem hiding this comment.
Oops, put this comment in the wrong place somehow - was meant for the lifetime comment.
-[Unknown]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11841 and likely fixes #11698.
Additionally, minor code cleanups.