Fix avi dump feature by using render buffer with option to use output buffer. #12069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, not sure if that's a good thing, although I guess if you want a clean image, you'll just turn all the overlay stuff off... |
Also make the dump messages shorter, especially dump start since it will be recorded.
|
Since avi dump cooperates nicely with savestates I blocked OSM for those when video is being dumped also made the OSM for dump shorter(especially start) to reduce annoyance as it will record into video. |
with an option to use output buffer since recording with post process effects will often be desirable.
LunaMoo
changed the title
hrydgard
reviewed
Jun 4, 2019
UI/GameSettingsScreen.cpp
Outdated
| @@ -813,6 +813,7 @@ void GameSettingsScreen::CreateViews() { | |||
| #if defined(_WIN32) || (defined(USING_QT_UI) && !defined(MOBILE_DEVICE)) | |||
| systemSettings->Add(new CheckBox(&g_Config.bDumpFrames, sy->T("Record Display"))); | |||
| systemSettings->Add(new CheckBox(&g_Config.bUseFFV1, sy->T("Use Lossless Video Codec (FFV1)"))); | |||
| systemSettings->Add(new CheckBox(&g_Config.bDumpVideoOutput, sy->T("Use output buffer(with overlay) for recording"))); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10632 as tested on 20 fps game.
Fixed with render buffer now:
Changing to output buffer means we're now recording also:
One other downside I found is that software rendering isn't recorded correctly with output buffer at least if the game draws by manually copying to vram like that Darkstalkers game which can't render in hardware renderer correctly. It recorded ok with display framebuffer, so maybe giving a choice of buffer for recording would be a nice option, through that's really an edge case.- software renderer recording overall works better with render buffer, through while testing now, it recorded fine even with output buffer, not sure why.