Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore mapped mouse input for UI #12173

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Conversation

LunaMoo
Copy link
Collaborator

@LunaMoo LunaMoo commented Jul 14, 2019

This is a workaround for a problem which will happen if user maps mouse actions like for example mouse wheel into psp buttons that does something else in the UI, especially cross or circle.

Might help #12156, but I can't reproduce that issue in any way on my system.

@LunaMoo LunaMoo added this to the v1.9.0 milestone Jul 14, 2019
@LunaMoo LunaMoo changed the title Disable mapped keys for UI if mouse control is active Ignore mapped mouse input for UI Jul 14, 2019
@LunaMoo
Copy link
Collaborator Author

LunaMoo commented Jul 14, 2019

Decided to change it a bit and just ignore mouse input in the UI, doesn't matter if mouse control is active or not since most mouse input can still be mapped without mouse control and could be mapped even after it get's disabled.

@i30817
Copy link

i30817 commented Jul 14, 2019

Does this also work for touchpads used as mouse? I stopped using standalone PPSSPP after i found the UI was automatically putting my touchpad as one of the PSP analog joysticks.

Which was a problem on the UI because moving the mouse cursor 'left' cause the menus to go 'back' as if both control methods were active. It was completely unusable in a 'subtle' way.

@LunaMoo
Copy link
Collaborator Author

LunaMoo commented Jul 14, 2019

If the touchpad is detected as DEVICE_ID_MOUSE then it's mapped controls will be ignored in the UI, but I don't use linux, nor I have a touchpad, so I have no clue how it is detected, nor what's your actual problem since analog axis doesn't really do anything in the UI on Windows.

@hrydgard
Copy link
Owner

I like this better than the original solution, will merge.

As for the linux touchpad problem, it should be reported in a separate issue with more details.

@hrydgard hrydgard merged commit 80b6d88 into hrydgard:master Jul 15, 2019
@LunaMoo LunaMoo deleted the mouseUIworkaround branch July 15, 2019 20:10
@i30817
Copy link

i30817 commented Jul 16, 2019

@hrydgard I had already did and was it was left open in #11139, but i can bump it with a new downloaded ppsspp and transcribe the ini files on ~/.config/ppsspp for the current version, which i should have done to confirm it's that the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants