Android OpenSL initial queue fix #12333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…startup. I don't actually think this matters much though. Seems to make absolutely no difference on any of my devices, but you never know.
…ttle data anyway (sizeof on dynamic buffer.. sigh). Anyway like I said, none of this really seems to matter.
|
Thanks for the credit! :) |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered (thanks to @jimmyw ) that I was queueing up the wrong amount of buffers and wrong size data when setting up OpenSL.
Fixing both issues and cleaning the code a little.
Android doesn't really seem to mind though, this doesn't appear to change anything about playback.