New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android][OpenGL&Vulkan][Graphic]Umezawa Yukari no Yasashii igo(ULJM05384) 梅沢由加里のやさしい囲碁 #12516
Comments
Looks like the usual pixel gap caused by scaling, the game's graphics are not really compatible with being rendered at higher resolution. Can you confirm how the image looks if you set Rendering Resolution to 1x? |
Hm, yeah, better but still a little visible. Is texture filter set to default? Our filtering is slightly off from the real PSP. I think a bunch of instances of this problem has been reported before though, but too lazy to find them right now so I'll just tag this for investigation... |
Yes,some settings are default. OK, I 'm just reporter!! |
Could you try exporting a GE frame dump? These help a lot. See here for instructions - it's not hard and works on Android too: You can zip that and then drag and drop it into a reply here. -[Unknown] |
Yes!! |
Interesting about this draw is that it uses s8 pos / u8 tc. That's relatively uncommon. It also uses texscale, but I don't think that's the issue. The character (with face cutouts) is drawn at (371.971680, 16.899780) - (466.986084, 271.01001). It looks like this: Filtering is set to linear/linear/linear (even though there are no mips.) The next draw with the actual face is not offset by any fraction of a pixel, which is why they are uneven. The coordinates are: (371.971680, 16.899780) - (466.986084, 271.01001) Forcing Y1 screenpos from 30862 to 30864 makes the Y look right (271 rounds down already.) Here's what it should look like, exactly: And here's how software rendering looks now: The offset is applied by the world matrix, I think. Maybe s8 positions round differently even at that level? -[Unknown] |
Is this same issue? or not? And,dump file here!! |
That one is harder to avoid. See here for an explanation: But it may be related. To fix the Easy Go game, we might have to add rounding that would make animations less smooth... -[Unknown] |
Umm...It's too difficult for me. ( ^_^ ;) |
Software rendering still gets this one wrong (linking to #16131.) It now has lines on the right side (X.) Drawing goes from 371.9375 (rounded) to 467 for the body, then 398.9375 to 414.9375 for the mouth (the only part that looks wrong.) But actually, it seems to be wrong already after 3/15 (the body.) I think this is sampling wrong, it seems to blend some of the transparent into the right side of the mouth. Forcing this draw to nearest confirms this to be the issue, for software rendering. Probably, it should draw at the next pixel center, and is currently only offsetting by half of something. In hardware, that's not the only draw with the problem, but it is part of the problem. Forcing only the body to nearest gives this: -[Unknown] |
What happens?
A black square line is indicated around the eye of the character and the mouth.
*OpenGL & Vulkan has same issue.
What should happen?
A black line goes off, and it's indicated right.
What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.
PPSSPP Ver. : 1.9.3-147
OS: Android 9.0
DeviceName: SONY SO-02K / Xperia XZ1 Compact (Japan)
CPU: Snapdragon835 (Octa-core)
GPU: Adreno 540
Resolution: 720×1280
RAM: 4GB
ROM:32GB
ExternalStrage: microSDXC 512GB
Please check screen shot & frame dump.
ULJM05384_0001.zip
The text was updated successfully, but these errors were encountered: