Touch control grid snap #12517
Merged
Touch control grid snap #12517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice change! Starting to get concerned that all the buttons on the left column of this screen will fit on small mobile devices though, gonna test it on a couple before merging. |
|
Commended out the top "Control" label, this should give more space for the other button on small devices (I don't think is was needed anyway). Edit: update the top screenshot with the screen from 720p android phone. |
|
In the future - maybe we could put Snap/Grid/Reset under an Options pop up. I like the idea of snap here, either way. LGTM. -[Unknown] |
This was referenced Jan 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a option to snap touch control position to a grid to make it easier to configure.