SDL analog mouse input #12612
Merged
SDL analog mouse input #12612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
reviewed
Feb 4, 2020
|
Fixed |
|
Sending KEY_UP right after was too fast for any game I tried (was working only on the bind menu), added mouse 3, 4 and 5 press as well to match windows version. |
|
Hm, what if there's not a next cycle? Maybe a timer (frame counter) to send a KEY_UP after a while? |
|
If is in the main loop, while (true), shouldn't there be always another cycle (unless the emulator get closed at least)? |
|
Oh right, for some reason I thought you meant next time you get a mousewheel event. Never mind, it seems right (but only one frame of down state might not always be enough). |
hrydgard
added
Input/Controller
|
Yeah, made it 5 (may be a bit too much, but it allow to simulate a hold if scrolled fast, still can be reduced) |
|
Yeah, we can tweak that as needed. Let's merge. |
This was referenced Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add analog mouse input to SDL, adding another platform to #4650.