Add toggle flag to combo button #12623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, are you happy with this as-is? Can't quite tell from the description. |
|
Yeah, I think even if it can be a bit weird with multiple button other solution will end up more confusing/complex with a single one (and i think one button toggle it's a more common use case than multiple ones). If you want to check how it is now the apk mentioned here have it: #12486 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add toggle mode to combo button (the combo button it self will not be hold in down animation, as it would make little sense as other input can override the held and there might be multiple button in the combo).
Should help use cases as #10159 a bit.
EDIT: it swap button separately if one is pressed and the other not when is activated, i dunno what should be the expected behaviour with multiple key toggle tho' (remember the last status and change them all? Loop to check if all have been released by other input before?).