GPU: Assume a scissor of 481x273 is a mistake #12746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already do this for viewport, and only when region is still a correct size. Helps flicker in Everybody's Golf.
unknownbrackets
added a commit
to unknownbrackets/ppsspp
that referenced
this pull request
May 21, 2020
Assume it's still wrong in this case and take 480x272. See hrydgard#12746.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already do this for viewport, and only when region is still a correct size. Helps flicker in Everybody's Golf. I think it's relatively safe.
See comments in #12355 - this was causing flicker. It's possible this is related to #6655, because I think this flicker only occurs on the green.
This doesn't fix the Vulkan perf issue mentioned there, though.
-[Unknown]