Real support "Hatsune Miku Project Diva Extend" chinese patched version #13007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is right. Tested on "Hatsune Miku Project Diva Extend" chinese patched version
hrydgard
reviewed
Jun 7, 2020
Core/HLE/sceKernelInterrupt.cpp
Outdated
| @@ -681,7 +681,7 @@ const HLEFunction Kernel_Library[] = | |||
| }; | |||
|
|
|||
| static u32 sysclib_memcpy(u32 dst, u32 src, u32 size) { | |||
| ERROR_LOG(SCEKERNEL, "Untested sysclib_memcpy(dest=%08x, src=%08x, size=%i)", dst, src, size); | |||
| DEBUG_LOG(SCEKERNEL, "Untested sysclib_memcpy(dest=%08x, src=%08x, size=%i)", dst, src, size); | |||
There was a problem hiding this comment.
I think you can just delete this logging, it's not really interesting.
|
@hrydgard done |
|
Can we add it to Readme ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify log https://gist.github.com/sum2012/ae24eff99712cd0e71c864a82623a9cc