Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request](Android) On-screen touch controls "Ignore camera notch" #13689

Open
Kzitold opened this issue Nov 21, 2020 · 6 comments
Open
Labels
Feature Request User Interface PPSSPP's own user interface / UX
Milestone

Comments

@Kzitold
Copy link

Kzitold commented Nov 21, 2020

Need an option for the touchscreen controls to ignore camera notch.

@Panderner
Copy link
Contributor

This option is not suitable for phones with bigger notches (Huawei Mate 20 Pro, Pocophone F1, Moto G7 Play, Motorola One, Xiaomi Mi 8, and iPhones with notches) because the on-screen controls are blocked by a notch.

@Panderner
Copy link
Contributor

and it's also not suitable for phones with dual punch-hole cameras placed on left (Mate 40, Realme 6 Pro, and Reno 4) in landscape mode.

@hrydgard
Copy link
Owner

What phone do you have where you would want this? Won't you just end up touching the camera all the time, getting the lens dirty?

@Kzitold
Copy link
Author

Kzitold commented Nov 22, 2020

What phone do you have where you would want this? Won't you just end up touching the camera all the time, getting the lens dirty?

I use a Samsung Galaxy S10, in default landscape mode (counterclockwise.)

Needed for symmetry. Want the L&R buttons, D-pad&ActionButtons, and left&right analogs the same distance from their respective sides of the game window while IgnoreScreenInsets = True

@hrydgard hrydgard added this to the v1.12.0 milestone Nov 22, 2020
@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Nov 22, 2020
@Kzitold Kzitold closed this as completed Nov 22, 2020
@Kzitold Kzitold reopened this Nov 22, 2020
@Kzitold
Copy link
Author

Kzitold commented Nov 22, 2020

and it's also not suitable for phones with dual punch-hole cameras placed on left (Mate 40, Realme 6 Pro, and Reno 4) in landscape mode.

It's more about having the controls using the same point of reference as the game screen.

@hrydgard hrydgard modified the milestones: v1.12.0, v1.13.0 Jul 5, 2021
@ghost
Copy link

ghost commented Feb 12, 2022

To add some clarifications, if you enable "Ignore notch when centering" and then edit the touchscreen layout to make them look symmetrical, the end result is that they won't be symmetrical. The game ignores notch while the control layout does not, thus their "center point" are different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

No branches or pull requests

3 participants