UI: Add button to show CRC on feedback screen #14041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to cause a wacky crash (strange callstack with exit handlers) by building in debug mode so it's a bit slow, starting a CRC computation, and exiting the emulator before it finished. Maybe doesn't matter too much though... |
Need to finish this before we delete the block device.
unknownbrackets
force-pushed
the
ui-crc
branch
from
21418a2
to
25b0be7
Compare
|
That was an existing issue with reporting, but I've changed it to block on shutdown and cancel early if possible. -[Unknown] |
Closed
|
CRC numbers and Back button in the info screen is overlapping each other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #14000, but shows on the reporting screen. If the CRC has already been calculated by some means (or perhaps if it's precalculated in the file format), shows on the game screen as well.
I think it might make sense to just show the button here.
-[Unknown]