Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Savestate load undo #14679

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Savestate load undo #14679

merged 3 commits into from
Aug 6, 2021

Conversation

iota97
Copy link
Contributor

@iota97 iota97 commented Aug 3, 2021

Create a savestate (shared between all game) before loading the selected one that can be used to undo the load.

About the UI, well I really dunno tbh... (Edit: remembered we had rewind button so placed it next to it)
Screenshot_2021-08-03_11-12-09

@iota97 iota97 marked this pull request as ready for review August 3, 2021 13:57
@hrydgard
Copy link
Owner

hrydgard commented Aug 3, 2021

Right, given that it's a global option, unlike the slot-specific undo-save, it doesn't really belong in the popups you get by clicking the image.

Maybe you can do a horizontal LinearLayout and put the buttons next to each other instead? Concerned about vertical space on small phone screens.

Undo latest save might also be convenient here.. Hm.

@iota97
Copy link
Contributor Author

iota97 commented Aug 3, 2021

Using horizontal layout it use the same vertical space as before with rewind I guess, may still need to scroll on some small device tho'.

Screenshot_2021-08-03_21-17-12

@hrydgard
Copy link
Owner

hrydgard commented Aug 3, 2021

Definitely an improvement!

I'll actually review the code tomorrow, but it's a great feature to have.

Also I would like to redesign the screen a bit to make it harder to accidentally misclick load/save, but that's another story, and quite difficult without losing convenience. There'll still be value in this either way.

Core/SaveState.cpp Outdated Show resolved Hide resolved
Core/SaveState.cpp Outdated Show resolved Hide resolved
Core/SaveState.cpp Outdated Show resolved Hide resolved
@hrydgard hrydgard added this to the v1.12.0 milestone Aug 6, 2021
@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Aug 6, 2021
@hrydgard hrydgard merged commit 86c5a17 into hrydgard:master Aug 6, 2021
@iota97 iota97 deleted the undo-load branch August 7, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants