Add Reset button on crash screen, allow load state and related #14708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we hold on and show this during stepping which is confusing.
And allow saving as well, since we can maybe resume.
This makes it so we can enable Stop/Reset/etc. during them in the menus.
|
Thanks, nice to clean this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, on a crash you could return to the pause screen (via button press), but the load state option wouldn't actually work - it'd go through the motions but stay crashed. Options in the Windows menu were disabled as well.
This enables load and save state, as well as rewind. It also makes the Stop and Reset options in the menu work. Fixes #14584.
Additionally, it adds a "Reset" button next to the "Resume" button (or alone, if you can't resume) as another way out. If a game crashed on a real PSP, it would actually reset the entire device automatically as far as I know (though not the game, to be fair.)
I've seen people post screenshots in game with a phatom Resume button visible on top of everything else. Not sure what that's about, don't see any potential for that... maybe it was a bug we already fixed, though.
-[Unknown]