softgpu: Remove offset from screenpos, adjust filtering coords #15410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies tighter calculations, and reduces the common magnitudes we'll be dealing with.
|
nice! |
hrydgard
approved these changes
Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous test only showed a specific scenario, but missed other cases. It ended up causing artifacts in the intro and pause screen of Kingdom Hearts, for example.
This is still not accurate, but it was pretty significantly wrong when a texture was sufficiently magnified. It makes more sense that x/y would have a lesser affect the greater the magnification.
This is still disabling the tests as noted in #15389, but I think adding more tests that show why the previous tests were too limited in scope is the better way to do that.
-[Unknown]