softgpu: Plug bad leak of bin queue data #15440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 32-bit, we still want these aligned to 16 bytes.
5 tasks
hrydgard
approved these changes
Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some possible crashes/issues remaining on 32-bit with the new software renderer queues, which this fixes.
More importantly, it turns out the draw engine for softgpu was never getting freed, which meant a lot of things attached to that never got freed either. This made memory usage steadily rise while running automated tests, and is likely the cause of #15434.
Fixes #15434 (at least builds from Visual Studio.)
-[Unknown]