Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple compat flag to workaround the Clone Wars issue, #12949 #15691

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

hrydgard
Copy link
Owner

Fixes #12949

Could probably also be fixed by changing the heuristic a bit, but since we're in heuristic land anyway and close to a release, I feel this is the safest option.

Also sneaks in a logspam reduction.

Could probably also be fixed by changing the heuristic a bit, but since
we're in heuristic land anyway and close to a release, I feel this is
the safest option.

Also sneaks in a logspam reduction
@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Jul 15, 2022
@hrydgard hrydgard added this to the v1.13.0 milestone Jul 15, 2022
@hrydgard hrydgard merged commit b233c2c into master Jul 15, 2022
@hrydgard hrydgard deleted the clone-wars-compat branch July 15, 2022 11:08
@ghost
Copy link

ghost commented Jul 15, 2022

How about Star Wars The Force Unleashed?
Fixes the red/blue overlay issue but still have graphics issue :(
Screenshot_2022-07-15-20-45-40-927_org ppsspp ppsspp

@hrydgard
Copy link
Owner Author

hrydgard commented Jul 15, 2022

That game I believe has quite a different issue.. Or did you mean that activating this flag for The Force Unleashed made a difference?

@ghost
Copy link

ghost commented Jul 16, 2022

AllowLargeFBTextureOffsets OFF
Screenshot_2022-07-16-01-11-46-100_org ppsspp ppsspp
Screenshot_2022-07-16-01-12-29-966_org ppsspp ppsspp

AllowLargeFBTextureOffsets ON
1X Resolution
Screenshot_2022-07-16-01-13-32-444_org ppsspp ppsspp
Screenshot_2022-07-16-01-13-59-959_org ppsspp ppsspp

2X Resolution
Screenshot_2022-07-16-01-14-21-280_org ppsspp ppsspp
Screenshot_2022-07-16-01-13-23-704_org ppsspp ppsspp

With lower resolution for effects (balanced) for Star Wars Force Unleashed @2x resolution fixes vertical line graphics issue.
Screenshot_2022-07-16-09-16-29-870_org ppsspp ppsspp

hrydgard added a commit that referenced this pull request Jul 16, 2022
We should probably reconsider the heuristic indeed.

Fixes #9572

See #15691
@ghost ghost mentioned this pull request Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Star Wars: The Clone Wars - Graphic glitch [Android/Windows]
1 participant