Core: Show exception on misaligned jump #15880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
reviewed
Aug 21, 2022
|
Looks good otherwise! |
unknownbrackets
force-pushed
the
ir-slowmem
branch
from
9c472da
to
8e7847f
Compare
hrydgard
approved these changes
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with #15879, I also just realized that the same goes for CPU jumps. Might as well just always validate alignment for those.
This also shows an RA when there's a bad jump. I'm too often seeing from/to PC being VRAM and the same value in screenshots, so I'm hoping this helps give more context on the errors.
-[Unknown]