GE Debugger: Add fields to register expressions #16007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easier to just refer to the full address.
This means a conditional breakpoint can now use, for example, vtype.through == 1 to check the through mode flag. No constants, but this makes it easier to get right. Would be nice to have an autocomplete of the field names, of course...
Hard to remember, but at least can be copy/pasted. Allows for things like "alphatest.func == GREATER".
|
looks good to me! and this will be quite useful for some investigations, for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #15974. This makes GE conditions easier to use, by providing a few more values, some constants, and fields. It also evaluates the expression as if the op had already run (at least for registers, not for matrix data or vtype, etc.)
For example, this allows you to add conditions like:
vtype.through == 1alphatest.func == GREATERtransfersrc == 0x08804000prim.type == TRIANGLE_FANfogcolor.red == 0xFFtexsize0.h == 512texfunc.func == GE_TEXFUNC_REPLACEWhich means you need to memorize less about the bits to evaluate expressions. It'd be nice to make this more friendly, but I already think this is better (and more usable from a debugger API, which doesn't exist yet but I plan for it to.) Of course, they're also useful for actual conditions.
Note: you can also use these when using "goto address" in a displaylist. You can't (yet?) use them in the memory viewer.
There's no way to discover these constants or field names aside from reading the code, but it'll error out at you if they're wrong.
This also gives metadata structure that might allow for "assembling" displaylist commands too.
-[Unknown]