softgpu: Cache reused indexed verts #16085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, meant to remove this when refactoring imm prims.
We can just use a dot product instead, and always skip viewpos.
This happens a lot for spline/bezier, so can significantly speed up curve heavy scenes. Isn't necessarily that common otherwise, though.
hrydgard
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the cost of ReadVertex() some, which can be especially heavy with curves. Improves the FPS of a frame dump from Metal Gear Ac!D 2 from ~30% to ~54%. The volume of triangles is still significant, so a lot of overhead is spent just clipping, queuing, etc. them.
This should improve other drawing that uses indices to reuse vertices, though likely not nearly to the same degree.
-[Unknown]