Make breakpoints work better in interpreter #16389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, only had these checks for memchecks before.
|
Very nice, this will do just fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs any CPU or memory breakpoints from the interpreter in a separate runloop, so there's not that much speed impact, and enables them in release. It does seem to be about 2-3% slower, but it seems to vary by the whims of the CPU a lot, I got less common timings that were faster by about 2% even.
Most people will be using IR or jit, so won't matter much anyway, I suppose. I guess this is good for completeness and comparing with IR or jit, especially the memory breakpoints.
Fixes #16311.
-[Unknown]