Correct misbehavior on uninitialized values in IR #16396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unlikely, but possible, uninitialized data could cause IsConsecutive4() to return true when n < 4.
None of these look at other lanes.
Just to prevent confusion/surprises, this is clearer.
unknownbrackets
added
the
IRInterpreter
This was referenced Nov 19, 2022
|
Oh, nice catches! |
1 similar comment
|
Oh, nice catches! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to clean this up more generally, but I think it was only an issue in VV2Op. Basically, it could be convinced to use Vec4 operations on size < 4, if stack happened to have consecutive values (perhaps from a previous Vec4 operation.)
See #10650.
-[Unknown]