Move post processing settings to the Display Layout Editor #16417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| BuildReportingInfo(); | ||
| configChanged_ = false; | ||
| } | ||
|
|
||
| // Check needed when running tests. |
There was a problem hiding this comment.
Well, it's really that the software renderer has no, and has no need for a, framebuffer manager. It's not just tests. Probably several of these things crash now when using the software renderer, since it wasn't in common before.
-[Unknown]
There was a problem hiding this comment.
Oh, it's fine because NotifyConfigChanged() does nothing on softgpu.
-[Unknown]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The post processing chain can now be directly tweaked on the Display Layout Editor screen, getting instant feedback.
The Display Layout Editor should probably be renamed now... Display setup? Just "Display"?
Also makes the game show through more screens, and minor tweaks.
Not sure whether stereo rendering also belongs here, getting the effect of toggling it will require running a frame...