softgpu: Expand fast path to all fb formats #16518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should speed up 2D games not using 5551, and make it mroe likely any regression is caught for Darkstalkers.
Wanted to avoid coupling these, but don't like the std::function construct/destructs showing in profiles...
This is common (for example, maybe a pixel state is updated but sampler is not), and reduces time spent in ComputeRasterizerState() quite a bit in Darkstalkers, where jits are available (i.e. Intel currently.)
Apparently we don't link libatomic and rather than fighting that, I'll just use thread local values.
unknownbrackets
force-pushed
the
softgpu-fastrect
branch
from
6a80fcc
to
3d7e867
Compare
unknownbrackets
force-pushed
the
softgpu-fastrect
branch
from
3d7e867
to
d9522a7
Compare
hrydgard
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also some more incremental improvements based on the frame dump. These are mainly from testing on PC, though.
I figure my chances of noticing the fast path being broken are higher if it is hit for more framebuffer formats...
-[Unknown]