Vulkan: Avoid race in compile thread exit #16689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknownbrackets
force-pushed
the
vk-shutdown
branch
from
e97c88f
to
6c79d94
Compare
|
Ah good catch, this should do it! |
hrydgard
approved these changes
Jan 1, 2023
|
As for vkDeviceWaitIdle, yeah, we could possibly remove it. Though, it's never going to get stuck in it, at least... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the lock, we could enter the wait at just the wrong moment, potentially causing a shutdown hang (see #16601.)
I also wonder if we should just remove vkDeviceWaitIdle...
-[Unknown]