Add support for integer scale factor for display #17224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe "Snap scale to PSP pixels"? Or "Snap to round scale" / "Snap to whole scale"? Not sure. I don't think "Integer scale factor" is bad, really. Integer sounds like a scary math term to some, though. -[Unknown] |
|
Yeah.. none of those really beat Integer scale factor by enough of a margin, and it's called that in some other emulators too. So I think I'll end up sticking with it. |
This is mainly useful if you want an authentic pixellated look with 1x rendering (or software) and nearest display filter. It'll simply round down the auto-scaled sized to the nearest integer scale factor, configuring exactly which one isn't that interesting since they all are gonna look good. Fixes #17093
hrydgard
force-pushed
the
integer-scaling
branch
from
1151cde
to
c08c711
Compare
|
Alright, ready for review. |
unknownbrackets
approved these changes
Apr 2, 2023
|
Thank you very much for this, it looks really good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly useful if you want an authentic pixellated look with 1x rendering (or software) and nearest display filter. Cave Story is a good game for testing.
The new option is a boolean, that'll simply round down the auto-scaled sized to the nearest integer scale factor, configuring exactly which one isn't that interesting since they all are gonna look good.
Fixes #17093
I'm not a huge fan of the name "Integer scale factor" but I don't really know what would be better, suggestions wanted.
(Oops, just realized that vertical screen rotation isn't gonna look good right now, will fix).