Don't try to present from little temp framebuffers used by Godfather to draw text #17298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to draw text. The framebuffer does contain the top of the video frame at the present time though, so things have partially gone well. However the rest of the frame lies after it in VRAM. What we probably technically should do when we see this is to assemble an image from both the framebuffer we find and VRAM contents exceeding the range of that image, but seems kinda impractical. This works, but there seems to be some other issue with how the text is rendered or copied. Could be a color precision issue confusing the game I suppose.
|
This is an improvement so I'll get it in, even though we still have more issues in #16915. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #16915, but the text is kinda hard to read, which is probably a separate issue.
The framebuffer does contain the top of the video frame at the present time though, so things have partially gone well. However the rest of the video frame lies after it in VRAM, while also overlapping it. What we probably technically should do when we see this is to assemble an image from both the framebuffer we find and VRAM contents exceeding the range of that image, but seems kinda impractical.
This works, but as mentioned there seems to be some other issue with how the text is rendered or copied. Could be a color precision issue confusing the game I suppose.
Savestate for repro (ppdmp useless in this case):
GodfatherSubtitles.zip