Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vrnd to the current understanding #17549

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Fix vrnd to the current understanding #17549

merged 1 commit into from
Jun 5, 2023

Conversation

fp64
Copy link
Contributor

@fp64 fp64 commented Jun 5, 2023

Followup to #17506.

@fp64
Copy link
Contributor Author

fp64 commented Jun 5, 2023

Ah, so checks also get a whole lot of /usr/include/features.h:194:3: warning: "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-W#warnings], not just my local build (well, it's -Wcpp locally).
I've seen a recommendation to use both _BSD_SOURCE and _DEFAULT_SOURCE, which CMakeLists.txt does in one place, but not the other. Not sure if appropriate.

@hrydgard hrydgard added this to the v1.16.0 milestone Jun 5, 2023
@hrydgard
Copy link
Owner

hrydgard commented Jun 5, 2023

I can't claim to understand how those defines are really meant to be used..

@hrydgard hrydgard merged commit 733b7b0 into hrydgard:master Jun 5, 2023
19 checks passed
@fp64 fp64 deleted the vrnd-fix branch June 5, 2023 12:25
@fp64 fp64 mentioned this pull request Jun 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CPU emulation
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fp64 @hrydgard