Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenXR - Major review #17636

Merged
merged 4 commits into from Jun 27, 2023
Merged

OpenXR - Major review #17636

merged 4 commits into from Jun 27, 2023

Conversation

lvonasek
Copy link
Contributor

  • Update of OpenXR runtimes to the latest (headset vendors bug fixes, smaller APK)
  • Optimize critical OpenXR code sections (reduces lagging)
  • Reverts workaround for PicoOS 5.3 (necessary to finish multiview or vulkan support)
  • Wrong view mirroring causing random glitches (Gran Turismo, Nascar, Flatout, etc.)

This fixes #16175 (in the issue were more bugs at the same time, the non-VR issues were already fixed by Unknown)

@hrydgard
Copy link
Owner

I'm okay with this, but I'm curious what the purpose is for the depth swapchain. Doesn't feel like one should be needed unless you want to integrate depth-wise with other running apps somehow - we don't output much depth anyway to the backbuffer.

@lvonasek
Copy link
Contributor Author

I'm okay with this, but I'm curious what the purpose is for the depth swapchain. Doesn't feel like one should be needed unless you want to integrate depth-wise with other running apps somehow - we don't output much depth anyway to the backbuffer.

It is easier way to initialize depth and stencil attachments for framebuffer. The same code for every renderer.

@hrydgard hrydgard added this to the v1.16.0 milestone Jun 27, 2023
@hrydgard hrydgard added the VR OpenXR VR support label Jun 27, 2023
@hrydgard hrydgard merged commit e422988 into hrydgard:master Jun 27, 2023
19 checks passed
@lvonasek lvonasek deleted the review_openxr branch June 27, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VR OpenXR VR support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken rendering in Need for Speed: Pro Street
2 participants