Implement color emoji support for Android #17854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added
Platform-specific (Android)
User Interface
| // ranges grabbed from https://stackoverflow.com/a/62898106, ignoring the two bogus ranges. | ||
| // there's probably more. Doesn't need to be perfect. | ||
| inline bool CodepointIsProbablyEmoji(uint32_t c) { | ||
| return (c >= 127744 && c <= 129782) || (c >= 126980 && c <= 127569); |
There was a problem hiding this comment.
Personally, I would just assume anything with characters outside the BMP (i.e. c > 0xFFFF) includes emoji. Unless someone is using Ancient Sumerian or Egyptian Hieroglyphics, that's probably the only reason most people will use non-BMP glyphs. I guess the other thing is advanced math symbols.
-[Unknown]
There was a problem hiding this comment.
Yeah, I guess that's the safer way to go...
| apiName += ", debug build"; | ||
| apiName += ", debug build "; | ||
| // Add some emoji for testing. | ||
| apiName += CodepointToUTF8(0x1F41B) + CodepointToUTF8(0x1F41C) + CodepointToUTF8(0x1F914); |
There was a problem hiding this comment.
Did you mean for this to stay? I mean, it's fine, just noting in case.
-[Unknown]
There was a problem hiding this comment.
yes, since it's debug build only :) and having them here is convenient for checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emoji are used in some RetroAchievement sets.
Actually, the platform renders color emoji just fine as it is, just that we squished away all the color when converting to our monochromatic font images. So now we switch to color if emoji is detected in text.
Windows is not included here. Easy for UWP, but more complicated for the normal build, we might be able to use the DirectWrite code we use on UWP, possibly, even in the non-UWP build. Standard windows GDI does not support color emoji.
No idea about Qt.
Part of #17631