Present modes refactor #17903
Merged
Present modes refactor #17903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headless/SDLHeadlessHost.cpp
Outdated
| @@ -166,6 +165,7 @@ bool GLDummyGraphicsContext::InitFromRenderThread(std::string *errorMessage) { | |||
| renderManager_->SetSwapFunction([&]() { | |||
| SDL_GL_SwapWindow(screen_); | |||
| }); | |||
| // TODO: Support SwapInterval | |||
There was a problem hiding this comment.
I'm not sure it's really necessary for headless either way, as long as it doesn't slow down and can still render. Ideally it shouldn't be presenting exactly, I guess, or it should but should always be immediate since it'll be in fast forward mode?
Seems like headless crashed or something with these changes, though. And that's even without an actual GPU, since it only runs softgpu on the GitHub runners.
-[Unknown]
There was a problem hiding this comment.
I think when adding this comment, I thought I was in a regular SDL backend, hah.
hrydgard
force-pushed
the
present-types-refactor
branch
from
a163fe1
to
d1b6aa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of ifdefs sprinkled around, the backends now report what present modes they support and whether they can change it dynamically without hitches, and we try to make some logical decisions. Also, this fixes a regression from the previous refactoring where D3D would no longer dynamically switch to IMMEDIATE when fast-forwarding.
This also enables the Vsync checkbox on Vulkan/Android, if MAILBOX/IMMEDIATE is available (not on all devices). Does seems to result in lower latency but less smooth framerate. In the future I hope to be able to get FIFO to the same latency.
I want to default Vsync to on on Android and off on PC, since previously it was defaulting to off everywhere but forced on on Android, so I renamed the INI setting, and made a new function to decide the default.
Also fixes the debug info issue mentioned in #17902 (comment)