Asserts and checks #18201
Merged
Asserts and checks #18201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,6 +45,7 @@ class PromiseTask : public Task { | |||
| template<class T> | |||
| class Promise { | |||
| public: | |||
| // Never fails. | |||
There was a problem hiding this comment.
(as long as you assume OOMs don't exist or exist as a separate catastrophe than failure.)
-[Unknown]
There was a problem hiding this comment.
True, but we're kinda screwed in several other ways simultaneously then. That said, "Never fails" is always a bit of an overconfident comment to put - but the meaning here is that there's no need to check for null return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more. Also, removes a unused variable.