Jit: Assert on bad exit numbers, allow two more exits per block #18247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -725,6 +725,9 @@ void Arm64Jit::UpdateRoundingMode(u32 fcr31) { | |||
| // though, as we need to have the SUBS flag set in the end. So with block linking in the mix, | |||
| // I don't think this gives us that much benefit. | |||
| void Arm64Jit::WriteExit(u32 destination, int exit_num) { | |||
| // TODO: Check destination is valid and trigger exception. | |||
There was a problem hiding this comment.
Note that sometimes code will have untaken invalid exits, such as jumps to zero and such. Usually they are breaks, though, but not always.
-[Unknown]
There was a problem hiding this comment.
Ah, good point. Will sneak in a comment update later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix an issue from #18116.
We should really do this exit tracking in a better way, but defer that to later.
I'm not even sure how more than 2 branches happen, but it really does look like they do in the logs. So bump it to 4. Trying to keep this change minimal.