[libretro] Black boxes over text in many games (offending commit identified)

[hizzlekizzle]

Game or games this happens in

ULUS-10522 Disgaea Infinite

What area of the game

The very first screen with the gray background and white menu text. This problem happens in a lot of games but this is a very easy one to test.

What happens

Instead of the normal white text, each letter is replaced with a black box. This started with commit 5373b8c. It happens with both vulkan and opengl renderers, so I figure it's the bit in TextureCacheCommon.cpp where it refuses to load invalidly sized textures (i.e., ones >512x512), as this appears in the log:
[libretro ERROR] [G3D] Bad texture dimensions: 2048x2048
This was reported on the RetroArch subreddit by someone using Android, but I was able to reproduce it in desktop Linux. I checked against standalone/Qt PPSSPP and the problem doesn't happen there, so it's libretro-specific.

What should happen

The text should render readable and white instead of black boxes, like this:

GE frame capture

Platform

libretro / Retroarch

Mobile phone model or graphics card

Intel IGP

PPSSPP version affected

all builds since 5373b8c

Last working version

fb8ad0c

Graphics backend (3D API)

Vulkan

Checklist

• Test in the latest git build in case it's already fixed.
• Search for other reports of the same issue.
• Try resetting settings or older versions and include if the issue is related.
• Try changing graphics settings to determine if one causes the glitch (especially speed hacks or enhancements/replacements.)
• Include logs or screenshots of issue.

[hrydgard]

yeah my bad, I'll fix it shortly.

[justafella]

I had a similar issue to report. I've downloaded the latest build but for me there is still something missing: the selector rectangle.

Before latest build:

After latest build:

I can still save/load from deduction

[hizzlekizzle]

@hrydgard oh man, thanks for the rapid response! Cheers!

[hispanico957]

I update now the core but the problem is still present, i try Ace Combat and Fifa 14 (On FireTV - Firestick 4K MAX 2° gen)

Hispa

[hrydgard]

Okay, that's really weird.. reopened.

[bslenul]

It's normal, the updated version of the core is not yet available from the core downloader, atm it's still downloading a previous version where the issue is not fixed yet.

But I can confirm it's fixed (tested with 8dab823):

[LunaMoo]

Thanks for the input @bslenul closing again.

[hispanico957]

YESSSSSSSS i try games and confirm :-)

Thank mate
Hispa