Tactics Ogre: Remove a redundant GPU readback operation #18599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we know for sure it's debug? I've always assumed there's probably some place (maybe not a very useful place, like in-game screenshots which some games had) it might be used, but just not most frames... -[Unknown] |
|
It really looks like it a junk readback since it's the first thing that happens in every frame, no matter what's on the screen. All other readbacks seem much more intentional and specific. That said, I suppose we will find out through reports if something is missing. This one is so weird that I'm willing to risk it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an old hack that has been discussed before but we never merged it.
Tactics Ogre does a lot of expensive GPU readbacks, that it then actually uses for various graphics tricks (it seems to blur things on the CPU, for example). But, it also makes one small completely redundant readback every frame. Getting rid of that one can actually be pretty impactful on mobile, so let's just do it.
Note that it's now possible to set the "Skip GPU readbacks" setting to "Copy to Texture" which seems to work okay in this game now and will improve performance drastically on mobile, but some effects are missing, as mentioned above.