Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add an option switch to use font files from the game ROM. #19111

Open
2 tasks done
GitUpYao opened this issue May 5, 2024 · 5 comments · May be fixed by #19115
Open
2 tasks done

Feature Request: Add an option switch to use font files from the game ROM. #19111

GitUpYao opened this issue May 5, 2024 · 5 comments · May be fixed by #19115
Labels
Patched-game Occurs only on patched or modified version of a game. PGF / sceFont Issue involves PGF fonts.

Comments

@GitUpYao
Copy link

GitUpYao commented May 5, 2024

What should happen

If some Chinese translation games use their own fonts, text will be missing, but as long as you change the name of "PSP_GAME\USRDIR\fonts.ppgf" in the game rom and replace it with "ppsspp\assets\flash0\font\jpn0.ppgf", you will be fine. Perfect solution to this problem.
2024
before use:
202402

After use:
202403

Who would this benefit

Many people who play Chinese translation games. I have been troubled by this problem for several years. I hope a switch can be added to toggle it.

Platform (if relevant)

None

Games this would be useful in

ULJS-00371-凉宫春日的追忆 汉化版

Other emulators or software with a similar feature

No response

Checklist

@sum2012 sum2012 added the PGF / sceFont Issue involves PGF fonts. label May 6, 2024
@sum2012
Copy link
Collaborator

sum2012 commented May 6, 2024

@GitUpYao Do you know other chinese patched games also same problem ?

@sum2012 sum2012 added the Patched-game Occurs only on patched or modified version of a game. label May 6, 2024
@sum2012
Copy link
Collaborator

sum2012 commented May 7, 2024

ppsspp v1.17.1-334 log:
https://gist.github.com/sum2012/e6710b7c5a0a4a083328d16d0c1088e3
13:53:714 user_main I[SCEMODULE]: HLE\sceKernelModule.cpp:2175 sceKernelStartModule(278,asize=00000000,aptr=00000000,retptr=00000000,00000000): faked (undecryptable module)
13:53:714 user_main I[LOADER]: HLE\sceKernelModule.cpp:1389 Module fontfuck: 0911b8f0 0911342c 09113454
13:53:722 user_main I[LOADER]: HLE\sceKernelModule.cpp:1504 Exporting ent 0 named fontfuck, 1 funcs, 1 vars, resident 09113510
13:53:722 user_main I[LOADER]: HLE\sceKernelModule.cpp:1504 Exporting ent 1 named sceLibFont, 15 funcs, 0 vars, resident 09113520
13:53:722 user_main W[LOADER]: HLE\sceKernelModule.cpp:815 Ignoring func export sceLibFont/67f17ed7, already implemented in HLE.
It use custom font library to load chinese font, zh_gb.pgf hack may be can remove at the same time when solve this issue

sum2012 added a commit to sum2012/ppsspp that referenced this issue May 7, 2024
It is using custom font library.
Fix hrydgard#19111
@sum2012 sum2012 linked a pull request May 7, 2024 that will close this issue
@GitUpYao
Copy link
Author

GitUpYao commented May 7, 2024

@GitUpYao你知道其他中国补丁游戏也有同样的问题吗?

Most games containing this issue have been fixed with Chinese patches. Maybe these are the last few. Thanks

@sum2012
Copy link
Collaborator

sum2012 commented May 8, 2024

@GitUpYao When I solve the problem , I also remove zh_gb.pgf (Chinese font) hack
You can test the preview.
https://github.com/hrydgard/ppsspp/actions/runs/9001182125?pr=19115#artifacts

@sum2012
Copy link
Collaborator

sum2012 commented May 10, 2024

@GitUpYao The patch haven't merged yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patched-game Occurs only on patched or modified version of a game. PGF / sceFont Issue involves PGF fonts.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants