Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd Birthday Overdive Graphic problem. #4121

Closed
Ritori opened this issue Oct 11, 2013 · 11 comments
Closed

3rd Birthday Overdive Graphic problem. #4121

Ritori opened this issue Oct 11, 2013 · 11 comments

Comments

@Ritori
Copy link

Ritori commented Oct 11, 2013

On forum :- http://forums.ppsspp.org/showthread.php?tid=613&pid=52490#pid52490

This problem only occur when mutilthread option is on but now on latest version both multithread option be on and off it give same broken graphic after overdive.

this bug don't exist in v0.9.1-1644-g09ff13d
fesf

and it broken with v0.9.1-1646-g8785838
esfes

@hrydgard
Copy link
Owner

So if you back out 8785838 alone, it works in the latest version?

@Ritori
Copy link
Author

Ritori commented Oct 11, 2013

@hrydgard
I still dunno how to remove someone is commit for test the result..
but it broken after v0.9.1-1646-g8785838 build.

@solarmystic
Copy link
Contributor

@hrydgard

I can confirm @Ritori's findings. The responsible commit is indeed, https://github.com/raven02/ppsspp/commit/2cdb2d1e1f4eb140ad1a038438c1952a3c57e85d merged into master with v0.9.1-1646-g8785838 8785838

Reverting that commit fixes the graphical issue in 3rd Birthday after an Overdive is done in ST mode. At least from what I can observe.

@hrydgard
Copy link
Owner

@raven02 , seems the added cycles isn't safe everywhere after all.. or it's a combination of timing issues.

@raven02
Copy link
Contributor

raven02 commented Oct 12, 2013

I will check this out shortly to see if a better added cycles can be used.

@raven02
Copy link
Contributor

raven02 commented Oct 12, 2013

heeehee just wonder how to use the overdrive? or if cyclesExecuted += 60 , works okay ?

@Ritori
Copy link
Author

Ritori commented Oct 12, 2013

@raven02 it work fine and don't broken after overdive if i edit cyclesExecuted += 300 to cyclesExecuted += 60 .

@raven02
Copy link
Contributor

raven02 commented Oct 12, 2013

Alright .Thanks.Wondering how about +100 ?

@Ritori
Copy link
Author

Ritori commented Oct 12, 2013

@raven02 you mean cyclesExecuted +=100 or cyclesExecuted +100?
if cyclesExecuted +=100 it still fine :)

sorry to take my time my laptor overheat need restart now...

@raven02
Copy link
Contributor

raven02 commented Oct 12, 2013

That's good .I think latest build now has been fixed this issue .Feel free to close it .

@Ritori
Copy link
Author

Ritori commented Oct 12, 2013

Okay thank :)

@Ritori Ritori closed this as completed Oct 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants