-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spline/Bezier #660
Comments
What's the easiest way to identify games that use these? -[Unknown] |
@Xele02 , the second column you can cut down to two hex digits :) and the third is only six. |
Very neat. * [Unknown] crosses his fingers that Qt will run okay from Visual Studio. -[Unknown] |
Hexyz Force appears to use splines (not sure to what capacity) during battle. -[Unknown] |
Jeanne d'Arc seems to be a great example of Bezier curves, the graphics are very broken without them implemented. -[Unknown] |
FWIW, LittleBigPlanet seems to crash when it hits bezier curves somewhere in the vertex reader or something. -[Unknown] |
I found these examples: https://github.com/pspdev/pspsdk/blob/master/src/samples/gu/splinesurface/splinesurface.c This seems to especially be an issue for some games, like FF4, but it turns out there are a bunch of games that use this for little effects here and there: http://report.ppsspp.org/logs/kind/4 But more examples might be helpful. -[Unknown] |
i dont know if this helps, i found this on google: http://www.goop.org/psp/gl/#bezier-patch |
JPCSP also has an implementation that we could look at. |
okay,jpcsp has a prob with locoroco also.in ppsspp,the middle part is missing bt the circular shape of the blobs r ok,in jpcsp the middle part is fine bt the blobs r squarish... |
it looks like neobrain started to implement spline to softgpu, can someone port it over? neobrain@d26c7c3 |
I might port it when he is done :-) |
Humm just wonder cannot see beizer code in softgpu .... |
Holy Cow ! SoftGPU produces correct graphic in LocoRoco !!! It is damn slow, but CORRECT !!! (^_^) |
It's actually not 100% correct but definitely good enough for loco roco :) Yeah, it's possible. I won't have time until after 0.9 though. |
Thank you Henrik !!!) |
@unknownbrackets , Ahh , forget spline = beizer |
OH MY GOD !!!! |
Oops, sorry - velocity is OK, it looks like jagginess cause that kind of reaction :) |
Oh, LocoRoco crashing randomly (but mostly at the end of 4th level or on counting screen)... |
The random loco roco crashes are sound related, we have some bug in the mixer. Will look at it soon. |
Wow, HQ much better and smoother :) It is not too smooth - it is better than on real PSP, because her hardware not so powerful... |
Nah, the texture looks stretched along the lighting lines, making it look too smooth :) |
yep, something is still wrong just look at firaga spell |
I know what's wrong, hang on. |
ok, try now. |
Great, firaga too? |
Firaga spell may rely on @Nezarn as i don't have that save :( |
Regarding bbox/bjump implementation , what we can expect it fixes in terms of graphical ? List of games using bjump/bounding box |
|
FF4 seems to crash sometimes when entering battle now with high quality beziers/splines on:
Locals: http://i.minus.com/igoymiVXlY1XG.png Also, in regards to Firaga, what it should look like can be seen in the video I linked above, at around 7-14 seconds in or so: https://www.youtube.com/watch?v=83vCkplpsMw |
Confirmed @thedax's findings in FFIV using 64bit PPSSPP, HQ Beziers and Splines, and an AMD/ATI graphics card. Strangely enough, it won't crash in the Debug builds no matter what, so I couldn't get a stack trace from them. Very, very easy to repro, just walk around on the world map and trigger a battle, game will instantly crash. Stack Trace:-
|
Hmm, It can be done more efficiently, but what if you add after: count += 6;
} This (both times) in Spline.cpp: count += 6;
}
if (count > 16000) {
break;
} Although, those vars can easily just be incorrect in release mode unfortunately. -[Unknown] |
The game (FFIV) has glitchy graphics with "Read Framebuffers to Memory" on so the option was never used during problem reproduction for the aforementioned issue. Read Framebuffers to Memory on |
FF4 doesn't need Read FB -> CPU/GPU, so yes it does happen with it off. The break statements do indeed prevent the crash. |
I've just done 5 battles, it doesnt crash for me. (i have nvidia, and using x64 build of ppsspp) |
What version of the game? EU? US? |
EU |
That'd probably explain it then. I use the US version, and I believe @solarmystic does, too. |
I'll take a look at this tomorrow, it's likely that a bug or two lurk in all the new spline code I added. |
I want to appeal to unknownbrackets. You can see games like Fight night and UFC Undisputed? Something these games ispravlyayutsya. Apologies for oftop. Write the answer in a relevant subject. |
FF4's HQ bezier/spline crash seems to be fixed now. I think it was from the changes Henrik made a few hours ago. |
HE FIXED IT OMG :DD |
I think the only issue remaining here might be texture coordinate scaling and stuff like that. I'm gonna consider it done as a feature, anything remaining is just minor bugs that can get their own issues :) |
PSP has some hardware to tesselate (turn into triangles) bezier and spline "patches" (2d curves).
While ambitious by the hw designers, turns out this is not actually very useful for games, so very few games use it. Puzzle Bobble uses it for rotating sprites for some reason, and I have a very simple hack for those.
We need a real implementation of these for some games though.
BEZIER:
SPLINE:
BOTH
The text was updated successfully, but these errors were encountered: