Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove that * selector #33

Open
olo2552 opened this issue Aug 11, 2018 · 0 comments
Open

Remove that * selector #33

olo2552 opened this issue Aug 11, 2018 · 0 comments
Assignees
Labels

Comments

@olo2552
Copy link
Collaborator

olo2552 commented Aug 11, 2018

I'm talking about this:
https://github.com/hs3city/hs3city.github.io/blob/ad43120d6dde71371a6c36af10101426db593a19/_sass/main.scss#L8

Asterisk selector is shiet, it's slow and often unpredictable. It also have specificity issues ( specificity 0 0 0 0). Use replacement used in normalize.css for instance (manually selecting every needed element). The even better way is to make asterisk() sass mixin.

@olo2552 olo2552 changed the title Remove that shit asterist selector Remove that * selector Aug 11, 2018
@olo2552 olo2552 added good first issue refactor Code refacotrring labels Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants