New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ping interval and timeout to player #304
Conversation
8c894fb
to
0bca7f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 88.57% 88.59% +0.02%
==========================================
Files 36 36
Lines 3632 3640 +8
==========================================
+ Hits 3217 3225 +8
Misses 415 415 |
66b72ed
to
0aa636a
Compare
Added a fix for metaclass conflict as reported in #305 |
@MatteoH2O1999 what's the default timeout ping? How did you encounter this issue? |
yep, this does fix the issue. |
@hsahovic, |
0aa636a
to
3ffa6f3
Compare
@MatteoH2O1999 this looks good - can you remove the metaclass fix (I fixed the gym version instead)? |
3ffa6f3
to
cc462e6
Compare
Sure, but won't pinning the gym version be limiting? |
It is, but the new gym version made some deeper changes to their base API (eg. what |
Sure thing: I'll take a look at it and see if I can figure something out. In the meantime I already removed the metaclass fix |
Sometimes showdown server could suffer from a lag spike, expecially on less powerful machines. This allows to increase or disable timeouts for the keepalive mechanism used by websockets.
@hsahovic let me know if you think this could be useful