Add macro block, subs attributes, global config support #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add macro block support - add subs attribute support (asciidoc variables) - add global plantuml config file include support (:plantuml-include:)
hsanson
approved these changes
Apr 30, 2022
ggrossetie
reviewed
Apr 30, 2022
| private | ||
|
|
||
| def insert_config_to_content(parent, config_path, content, attrs) | ||
| File.open(config_path) do |file| |
There was a problem hiding this comment.
@hsanson We need to be careful about File.open because this library is used in GitLab where it might be a security threat.
I would recommend to check Asciidoctor safe mode before trying to read something from the filesystem. We should also make sure that the file does not reside outside of the parent directory of the source file (otherwise it could be used to read /etc/passwd or other sensitives files)
There was a problem hiding this comment.
Thanks for the advice. Will consider this potential risk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add macro block support
includes #19
closes #18
Add subs attribute support (AsciiDoc variables)
closes #17
Add global PlantUML config file include support with
:plantuml-include:Support a global PlantUML configuration file.
Add the functionality of the PlantUML command line: https://plantuml.com/command-line#6a26f548831e6a8c
Other tools such as Kroki have similar features with
:kroki-plantuml-include: path/to/file.puml.How to use
Just add the variable
:plantuml-include: path/to/file.pumlinside your AsciiDoc file.