Pub ack #83
Closed
Pub ack #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As newer versions refuse to work so far I used the working version from Arduino Uncommenting "#define USE_ETHERNET true" uses EthernetClient/EthernetServer works with W5500
added RP2040, using Ethernet (for example for W5500 EVB pico)
Apply richievos memory leak fix
apply richievos memory leak fix
Brought up to the latest branch (main) and added SubAck packets.
reduces network traffic from unnecessary Dup packets
hsaturn
reviewed
May 6, 2023
|
I have altered the PR to include the fix for #84 already. This might save you having to test twice. The fix for #84 was borrowed from this PR anyway, I just had originally kept the bit manipulation out your code as I was not sure if the omission was intentionally. The revised PR has the fix moved up a few lines to take effect in the earlier code too and corrected a mistake I had made (&& instead of &). Instead of using PublishID() it would also be possible to fetch the ID bytes straight from [payload], this would prevent misuse of PublishID() out of context. |
|
Thans for the PR, I'm closing it but have reflected changes with a unit test in 90435b1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion as per discussion.
It solves duplicate packets