This repository has been archived by the owner on Apr 15, 2018. It is now read-only.
Node should leave the cluster when Constructr is terminated (closes #119) #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case Terminated(`machine`) => { | ||
| val cluster = Cluster(context.system) | ||
| val self = cluster.selfAddress | ||
| if (cluster.state.members.exists(member => member.address == self && member.status == Up)) { |
There was a problem hiding this comment.
I don't think this check is needed, Akka Cluster should take care itself.
There was a problem hiding this comment.
This check is needed to terminate the actor system in case the node is not member of the cluster yet.
For instance a system initialization problem that prevent the node from joining the cluster. In this case a leave won't do anything and the system won't be terminated.
berardino
force-pushed
the
119-leave-cluster-when-terminated
branch
from
0cae548
to
8af503e
Compare
|
Hmm ... Travis failing ... I'll rerun it. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.