feat: create replies directly out of handle_cmd using closure #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qrilka
reviewed
Apr 9, 2024
hseeberger
reviewed
Apr 9, 2024
jrudolph
commented
Apr 10, 2024
jrudolph
commented
Apr 10, 2024
|
|
||
| fn make_reply(&self, id: &E::Id, state: &E, evt: E::Evt) -> BoxedAny { | ||
| Box::new(self.make_reply(id, state, evt)) | ||
| fn handle_cmd(self: Box<Self>, id: &E::Id, state: &E) -> BoxedCmdEffect<E> { |
There was a problem hiding this comment.
TIL self: Box<Self> to allow owning Box<dyn ...> values in trait functions.
|
Works fine here, too: hseeberger/rusty-accounts#25 |
jrudolph
commented
Apr 10, 2024
|
Looking good! Even though for replies one still might have to match on state (and panic on the wrong variants), there are some significant improvements, e.g. the handlers consuming cmd/evt. |
Closed
Ugh, that's still ugly but probably little we can do about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed a similar solution before in #201 (comment)
It now came up again that
make_replyis hard to use when you need access to the event. In that case the previous solution required manual correlation of the event created inhandle_cmdwith the event passed tomake_reply. The only way would to unpack the right event type would be to panic on all the other event cases which is inconvenient (in simple cases) and a potential for runtime panics (in more complex cases)./cc @qrilka