typescript(vx-shape): Re-write package in TypeScript #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rudeg
reviewed
Sep 20, 2019
Rudeg
reviewed
Sep 21, 2019
williaster
force-pushed
the
chris--typescript-vx-shape
branch
from
4ece259
to
d91090e
Compare
This was referenced Oct 2, 2019
hshoff
requested changes
Oct 8, 2019
| value: number | NumAccessor, | ||
| ) { | ||
| if (typeof value === 'number') func(value); | ||
| else func(value); |
There was a problem hiding this comment.
this one is so weird. asked mohsen about it and he wasn't sure 🤔
packages/vx-shape/src/shapes/link/curve/LinkHorizontalCurve.tsx
Outdated
Show resolved
Hide resolved
added 17 commits
October 9, 2019 08:49
…res to omit own props
williaster
force-pushed
the
chris--typescript-vx-shape
branch
from
016edcd
to
d5cee59
Compare
|
whew. lots of test errors that didn't always show up locally 🤔 |
hshoff
approved these changes
Oct 10, 2019
| data, | ||
| path, | ||
| x = (d: $TSFIXME) => d.y, // note this returns a y value | ||
| y = (d: $TSFIXME) => d.x, // note this returns a y value |
There was a problem hiding this comment.
not a blocker but the second commend should be x value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
This PR builds off #488 which introduces
Typescriptbuild config, and re-writes the@vx/shapepackage inTypeScript. Unfortunately this package is one of the biggest ones, so this PR is pretty sizable and larger than the other re-writes.A couple of notes:
@types/d3-pathand@types/d3-shapedependencies so that we can leverage/propagate existing types in our d3 usage.@vx/pointdependency .Types.💥 Breaking Changes
React.Fragments, which requires bumping thepeerDepforreactto^16.3.0-0@vx/shapetheArccentroidprop was removed as it was not functional (it was called as if it was anarc.centroid()configuration parameter, but in reality the.centroidmethod is for returning the centroid of a datum.@vx/shapetheAreacomponent is no longer wrapped in an empty<g>elementpropTypesacross all components are likely stricter.children(...)render function overrides are wrapped inReact.Fragments<>{children(...)</>to satisfy Types.orderandoffsetprops forStack,BarStack,BarStackHorizontal, andAreaStackpreviously supported strings, arrays, or functions. Only thestringprop was functional, and only the enumeratedstringpresets are now allowed.Closes #506
Testing
/gallery.d.tsfiles@hshoff @schillerk @milesj @techniq @kristw